Re: [Qemu-devel] [PATCH 2/2 v2] Adding BAR0 for e500 PCI controller

[Bhushan Bharat-R65777]

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Wednesday, October 10, 2012 4:08 AM
> To: Bhushan Bharat-R65777
> Cc: address@hidden; address@hidden; address@hidden; address@hidden;
> Bhushan Bharat-R65777
> Subject: Re: [Qemu-devel] [PATCH 2/2 v2] Adding BAR0 for e500 PCI controller
> 
> On 10/09/2012 01:19:10 PM, Bharat Bhushan wrote:
> > +static int e500_ccsr_initfn(SysBusDevice *dev) {
> > +    PPCE500CCSRState *pci_ccsr;
> > +
> > +    pci_ccsr = CCSR(dev);
> > +    memory_region_init(&pci_ccsr->ccsr_space, "e500-ccsr",
> > +                       MPC8544_CCSRBAR_SIZE);
> > +    return 0;
> > +}
> 
> Is this object supposed to represent CCSR (which is what the type name seems 
> to
> imply, along with the existence of a different
> PPCE500PCIBridgeState) or PCI BAR0 (which is what pci_ccsr seems to imply, 
> along
> with the fact that it's being added in the PCI patch)?

It is ccsr, I will correct this naming.

Thanks
-Bharat