[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/8] qxl: always update displaysurface on resize
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 1/8] qxl: always update displaysurface on resize |
Date: |
Mon, 8 Oct 2012 12:49:44 +0200 |
Don't try to be clever and skip displaysurface reinitialization in case
the size hasn't changed. Other parameters might have changed
nevertheless, for example depth or stride, resulting in rendering being
broken then.
Trigger: boot linux guest with vesafb, start X11, make sure both vesafb
and X11 use the display same resolution. Then watch X11 screen being
upside down.
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/qxl-render.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/hw/qxl-render.c b/hw/qxl-render.c
index e2e3fe2..b66c168 100644
--- a/hw/qxl-render.c
+++ b/hw/qxl-render.c
@@ -99,7 +99,6 @@ static void qxl_render_update_area_unlocked(PCIQXLDevice *qxl)
{
VGACommonState *vga = &qxl->vga;
int i;
- DisplaySurface *surface = vga->ds->surface;
if (qxl->guest_primary.resized) {
qxl->guest_primary.resized = 0;
@@ -112,9 +111,6 @@ static void qxl_render_update_area_unlocked(PCIQXLDevice
*qxl)
qxl->guest_primary.qxl_stride,
qxl->guest_primary.bytes_pp,
qxl->guest_primary.bits_pp);
- }
- if (surface->width != qxl->guest_primary.surface.width ||
- surface->height != qxl->guest_primary.surface.height) {
if (qxl->guest_primary.qxl_stride > 0) {
qemu_free_displaysurface(vga->ds);
qemu_create_displaysurface_from(qxl->guest_primary.surface.width,
--
1.7.1
- [Qemu-devel] [PULL 0/8] spice patch queue, Gerd Hoffmann, 2012/10/08
- [Qemu-devel] [PATCH 3/8] qxl: fix range check for rev3 io commands., Gerd Hoffmann, 2012/10/08
- [Qemu-devel] [PATCH 8/8] qxl: set default revision to 4, Gerd Hoffmann, 2012/10/08
- [Qemu-devel] [PATCH 6/8] hw/qxl: qxl_dirty_surfaces: use uintptr_t, Gerd Hoffmann, 2012/10/08
- [Qemu-devel] [PATCH 7/8] spice: raise requirement to 0.12, Gerd Hoffmann, 2012/10/08
- [Qemu-devel] [PATCH 1/8] qxl: always update displaysurface on resize,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 5/8] hw/qxl: fix condition for exiting guest_bug, Gerd Hoffmann, 2012/10/08
- [Qemu-devel] [PATCH 2/8] qxl/update_area_io: cleanup invalid parameters handling, Gerd Hoffmann, 2012/10/08
- [Qemu-devel] [PATCH 4/8] hw/qxl: exit on failure to register qxl interface, Gerd Hoffmann, 2012/10/08
- Re: [Qemu-devel] [PULL 0/8] spice patch queue, Anthony Liguori, 2012/10/12