Re: [Qemu-devel] [PATCH 10/14] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

[Alon Levy]

On Fri, Sep 28, 2012 at 11:51:29AM +0200, Paolo Bonzini wrote:
> Il 06/09/2012 09:21, Gerd Hoffmann ha scritto:
> > +#ifndef CONFIG_QXL_IO_MONITORS_CONFIG_ASYNC
> > +/* spice-protocol is too old, add missing definitions */
> > +#define QXL_IO_MONITORS_CONFIG_ASYNC (QXL_IO_FLUSH_RELEASE + 1)
> > +#endif
> > +
> 
> I don't see the need for this, why can't you just bump the minimum
> required version of spice-protocol?  Or import the headers (and only the
> headers) in QEMU?

Sorry for the late reply.

Gerd wanted to bump the protocol version once after we do a release of
spice-protocol and spice-server, which has happened now so this patch
should be only an intermediate state that will be removed when
spice-protocol is bumped like you suggest.

Importing spice-protocol headers is ugly, I would rather not maintain
them twice (I do plan on doing it in the linux kernel but there I see no
other choice).

> 
> Also, please consider adding the library version in the spice-protocol
> header files, so that you do not need
> CONFIG_QXL_IO_MONITORS_CONFIG_ASYNC at all.

spice-protocol is a separate repository from spice library.

Adding the spice-protocol dependency as a submodule would have been my
preferred solution but it has been shot down by Anthony.

> 
> Paolo
>