|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501) |
Date: | Fri, 05 Oct 2012 14:46:48 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
Il 05/10/2012 14:43, Jan Kiszka ha scritto: >>> >> This "| 1" might be the problem. Anthony, are you relying on it in >>> >> qemu-test and/or can you work out the changes if we use just >>> >> "exit(val)"? >> > >> > The reason for ' | 1' was to make sure that the guest couldn't trigger >> > an exit(0). >> > >> > If there's a compelling reason to drop '| 1', I can adjust my tests >> > accordingly. > assert(val); (or hw_error) > exit(val); > > I would suggest. I think what the kvm_unittests want is exactly to trigger an exit(0). Why did you rule it out? Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |