[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/18] migration (outgoing): add error propagati
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 08/18] migration (outgoing): add error propagation for fd and exec protocols |
Date: |
Fri, 05 Oct 2012 14:44:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
Il 05/10/2012 14:41, Luiz Capitulino ha scritto:
>>> > > That DPRINTF() usage is really bizarre, it seems its purpose is to
>>> > > report
>>> > > an error to the user, but that's a debugging call.
>>> > >
>>> > > I'd let it there and replace it later with proper tracing code, but
>>> > > that's
>>> > > quite minor for me. Please, at least mention you're dropping it in the
>>> > > log.
>> >
>> > This one is not dropped, it becomes the reported error message.
> What I meant is that the error/debug message won't be printed the same way
> it was before. This is an improvement, but it's a good idea to mention it.
>
I mentioned it for fd, but the popen() function only returns NULL if the
fork(2) or pipe(2) calls fail, or if it cannot allocate memory, so I
have no idea how to trigger it.
>> It would also fix the clobbering of errno.
>
> I guess so. Is it possible for popen() to return success but then set the
> FILE's fd to -1?
No. I will add the assert().
Paolo
- Re: [Qemu-devel] [PATCH 04/18] qemu-sockets: add nonblocking connect for Unix sockets, (continued)
[Qemu-devel] [PATCH 11/18] nbd: ask and print error information from qemu-sockets, Paolo Bonzini, 2012/10/03
[Qemu-devel] [PATCH 12/18] qemu-ga: ask and print error information from qemu-sockets, Paolo Bonzini, 2012/10/03
[Qemu-devel] [PATCH 10/18] qemu-char: ask and print error information from qemu-sockets, Paolo Bonzini, 2012/10/03
[Qemu-devel] [PATCH 17/18] qemu-sockets: add error propagation to inet_parse, Paolo Bonzini, 2012/10/03
[Qemu-devel] [PATCH 15/18] qemu-sockets: add error propagation to inet_connect_addr, Paolo Bonzini, 2012/10/03