[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v1 17/22] memory: use AddressSpace for MemoryListe
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [RFC v1 17/22] memory: use AddressSpace for MemoryListener filtering |
Date: |
Thu, 4 Oct 2012 16:57:06 +0000 |
On Thu, Oct 4, 2012 at 10:17 AM, Avi Kivity <address@hidden> wrote:
> On 10/03/2012 10:16 PM, Blue Swirl wrote:
>>> @@ -141,7 +141,7 @@ static bool memory_listener_match(MemoryListener
>>> *listener,
>>> #define MEMORY_LISTENER_UPDATE_REGION(fr, as, dir, callback) \
>>> MEMORY_LISTENER_CALL(callback, dir, (&(MemoryRegionSection) { \
>>> .mr = (fr)->mr, \
>>> - .address_space = (as)->root, \
>>> + .address_space = (as), \
>>
>> Maybe remove parenthesis.
>
> I prefer to keep it for consistency and defensiveness, unless you insist.
I don't, though for example dir is used a few lines earlier without parenthesis.
>
>
> --
> error compiling committee.c: too many arguments to function
Re: [Qemu-devel] [RFC v1 19/22] memory: per-AddressSpace dispatch, Anthony Liguori, 2012/10/04
[Qemu-devel] [RFC v1 17/22] memory: use AddressSpace for MemoryListener filtering, Avi Kivity, 2012/10/03
Re: [Qemu-devel] [RFC v1 17/22] memory: use AddressSpace for MemoryListener filtering, Anthony Liguori, 2012/10/04
[Qemu-devel] [RFC v1 18/22] s390: avoid reaching into memory core internals, Avi Kivity, 2012/10/03
Re: [Qemu-devel] [RFC v1 00/22] Integrate DMA into the memory API, Blue Swirl, 2012/10/03
Re: [Qemu-devel] [RFC v1 00/22] Integrate DMA into the memory API, Avi Kivity, 2012/10/04
Re: [Qemu-devel] [RFC v1 00/22] Integrate DMA into the memory API, Paolo Bonzini, 2012/10/04