qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC v1 17/22] memory: use AddressSpace for MemoryListe


From: Blue Swirl
Subject: Re: [Qemu-devel] [RFC v1 17/22] memory: use AddressSpace for MemoryListener filtering
Date: Thu, 4 Oct 2012 16:57:06 +0000

On Thu, Oct 4, 2012 at 10:17 AM, Avi Kivity <address@hidden> wrote:
> On 10/03/2012 10:16 PM, Blue Swirl wrote:
>>> @@ -141,7 +141,7 @@ static bool memory_listener_match(MemoryListener 
>>> *listener,
>>>  #define MEMORY_LISTENER_UPDATE_REGION(fr, as, dir, callback)            \
>>>      MEMORY_LISTENER_CALL(callback, dir, (&(MemoryRegionSection) {       \
>>>          .mr = (fr)->mr,                                                 \
>>> -        .address_space = (as)->root,                                    \
>>> +        .address_space = (as),                                          \
>>
>> Maybe remove parenthesis.
>
> I prefer to keep it for consistency and defensiveness, unless you insist.

I don't, though for example dir is used a few lines earlier without parenthesis.

>
>
> --
> error compiling committee.c: too many arguments to function



reply via email to

[Prev in Thread] Current Thread [Next in Thread]