[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems
From: |
Alex Williamson |
Subject: |
Re: [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems |
Date: |
Tue, 02 Oct 2012 08:37:05 -0600 |
On Tue, 2012-10-02 at 08:11 +0200, Paolo Bonzini wrote:
> Il 01/10/2012 20:49, Alex Williamson ha scritto:
> >> > @@ -768,7 +768,7 @@ static int vfio_dma_map(VFIOContainer *container,
> >> > target_phys_addr_t iova,
> >> > struct vfio_iommu_type1_dma_map map = {
> >> > .argsz = sizeof(map),
> >> > .flags = VFIO_DMA_MAP_FLAG_READ,
> >> > - .vaddr = (__u64)vaddr,
> >> > + .vaddr = (__u64)(intptr_t)vaddr,
>
> Does this need to be uintptr_t?
With a simple test program, I don't seem to get sign extension either
way. Logically uintptr_t seems preferable to me. I'll add a patch to
my tree. Thanks,
Alex