Re: [Qemu-devel] [PATCH v2 2/9] qapi: add socket address types

[Eric Blake]

On 10/01/2012 08:52 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  qapi-schema.json | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file modificato, 53 inserzioni(+)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 191d921..b443a99 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -2367,6 +2367,59 @@
>      'opts': 'NetClientOptions' } }
>  
>  ##
> +# @IPSocketAddress
> +#
> +# Captures a range of possible destination addresses for an IP socket
> +#
> +# @host: host part of the address
> +#
> +# @port: port part of the address, or lowest port if @to is present
> +#
> +# @to: highest port to try
> +#
> +# @ipv4: whether to accept IPv4 addresses, default try both IPv4 and IPv6
> +#        #optional
> +#
> +# @ipv6: whether to accept IPv6 addresses, default try both IPv4 and IPv6
> +#        #optional
> +#
> +# Since 1.3
> +##
> +{ 'type': 'IPSocketAddress',
> +  'data': {
> +    'host': 'str',
> +    'port': 'str',
> +    '*to': 'uint16',

I still think it's a bit weird to have:

'host':'localhost', 'port':'1000', 'to':1001

for a port range, all because of the possibility of named ports; should
'*to' be a 'str' if only for symmetry in the output?  But it's
bike-shedding, so I'll live with whatever works (that is, I'm not
requesting a v3 on this patch).

> +##
> +# @SocketAddress
> +#
> +# Captures the address of a socket, which could also be a named file 
> descriptor
> +#
> +# Since 1.3
> +##
> +{ 'union': 'SocketAddress',
> +  'data': {
> +    'inet': 'IPSocketAddress',
> +    'unix': 'UnixSocketAddress',
> +    'fd': 'String' } }

I guess you had to use the String wrapper instead of 'str'; but a bit of
reading in the file showed that this part is at least correct.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature