[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] device tree: simplify dumpdtb code
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] device tree: simplify dumpdtb code |
Date: |
Mon, 1 Oct 2012 21:15:08 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sun, Sep 23, 2012 at 11:29:32PM +0200, Alexander Graf wrote:
> As per Peter's suggestion, we can use glib to write out a buffer in whole to
> a file, simplifying the code dramatically.
>
> Signed-off-by: Alexander Graf <address@hidden>
>
> ---
>
> This patch applies on top of the generic dumpdtb remodeling patch.
>
> ---
> device_tree.c | 9 +--------
> 1 files changed, 1 insertions(+), 8 deletions(-)
>
> diff --git a/device_tree.c b/device_tree.c
> index 69ca953..a923613 100644
> --- a/device_tree.c
> +++ b/device_tree.c
> @@ -314,14 +314,7 @@ void qemu_devtree_dumpdtb(void *fdt, int size)
> const char *dumpdtb = qemu_opt_get(machine_opts, "dumpdtb");
> if (dumpdtb) {
> /* Dump the dtb to a file and quit */
> - FILE *f = fopen(dumpdtb, "wb");
> - size_t len;
> - len = fwrite(fdt, size, 1, f);
> - fclose(f);
> - if (len != size) {
> - exit(1);
> - }
> - exit(0);
> + exit(g_file_set_contents(dumpdtb, fdt, size, NULL) ? 0 : 1);
> }
> }
>
Reviewed-by: Aurelien Jarno <address@hidden>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH] device tree: simplify dumpdtb code,
Aurelien Jarno <=