Re: [Qemu-devel] [PATCH 10/14] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

[Paolo Bonzini]

Il 06/09/2012 09:21, Gerd Hoffmann ha scritto:
> +#ifndef CONFIG_QXL_IO_MONITORS_CONFIG_ASYNC
> +/* spice-protocol is too old, add missing definitions */
> +#define QXL_IO_MONITORS_CONFIG_ASYNC (QXL_IO_FLUSH_RELEASE + 1)
> +#endif
> +

I don't see the need for this, why can't you just bump the minimum
required version of spice-protocol?  Or import the headers (and only the
headers) in QEMU?

Also, please consider adding the library version in the spice-protocol
header files, so that you do not need
CONFIG_QXL_IO_MONITORS_CONFIG_ASYNC at all.

Paolo