|
From: | Wenchao Xia |
Subject: | Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system |
Date: | Fri, 28 Sep 2012 11:04:27 +0800 |
User-agent: | Mozilla/5.0 (Windows NT 5.1; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 |
δΊ 2012-9-27 18:17, Paolo Bonzini ει:
Il 27/09/2012 11:56, Wenchao Xia ha scritto:+$(LIBQBLOCK_TEST_DIR): + @echo "Make libqblock test directory" + mkdir $(LIBQBLOCK_TEST_DIR)You can leave the files in tests/ directly, and avoid this as well.Having a new directory will make clean easier, otherwise the script will need to know each image file names created, whose filename are generated in test C code at runtime.If you want a subdirectory for images, you can create it in the test code.
My original idea is creating and deleting them in C test code, but I found that there is many "assert" in the code, which may cause the clean step missing. So I think it is simpler to clean them in Makefile, make sure the temporal files are deleted.
Paolo
-- Best Regards Wenchao Xia
[Prev in Thread] | Current Thread | [Next in Thread] |