qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 25/45] block: introduce BLOCK_JOB_READY event


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 25/45] block: introduce BLOCK_JOB_READY event
Date: Wed, 26 Sep 2012 18:01:10 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1

On 09/26/2012 09:56 AM, Paolo Bonzini wrote:
> Even for jobs that need to be manually completed, management may want
> to take care itself of the completion, not requiring the user to issue
> a command to terminate the job.  In this case we want to avoid that
> they poll us continuously, waiting for completion to become available.
> Thus, add a new event that signals the phase switch and the availability
> of the block-job-complete command.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---

>  
> +BLOCK_JOB_READY
> +---------------
> +
> +Emitted when a block job is ready to complete.
> +
> +Data:
> +
> +- "device": device name (json-string)
> +
> +Example:
> +
> +{ "event": "BLOCK_JOB_READY",
> +    "data": { "device": "ide0-hd1",
> +              "operation": "write",
> +              "action": "stop" },

You didn't document operation and action; are you missing documentation
for this event, or are they bad copy-and-paste in the example?

Again, libvirt would really like to have 'type':'mirror' in the data,
for symmetry with all the other BLOCK_JOB_* events.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]