[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/7] target-s390x: Use CPU_LOG_INT
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 5/7] target-s390x: Use CPU_LOG_INT |
Date: |
Wed, 26 Sep 2012 00:45:21 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Sep 24, 2012 at 02:55:51PM -0700, Richard Henderson wrote:
> Three places in the interrupt code did we not honor the mask.
>
> Cc: Alexander Graf <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target-s390x/helper.c | 7 ++++---
> target-s390x/misc_helper.c | 3 ++-
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/target-s390x/helper.c b/target-s390x/helper.c
> index a5741ec..22256b0 100644
> --- a/target-s390x/helper.c
> +++ b/target-s390x/helper.c
> @@ -511,7 +511,8 @@ static void do_program_interrupt(CPUS390XState *env)
> break;
> }
>
> - qemu_log("%s: code=0x%x ilc=%d\n", __func__, env->int_pgm_code, ilc);
> + qemu_log_mask(CPU_LOG_INT, "%s: code=0x%x ilc=%d\n",
> + __func__, env->int_pgm_code, ilc);
>
> lowcore = cpu_physical_memory_map(env->psa, &len, 1);
>
> @@ -575,8 +576,8 @@ static void do_ext_interrupt(CPUS390XState *env)
>
> void do_interrupt(CPUS390XState *env)
> {
> - qemu_log("%s: %d at pc=%" PRIx64 "\n", __func__, env->exception_index,
> - env->psw.addr);
> + qemu_log_mask(CPU_LOG_INT, "%s: %d at pc=%" PRIx64 "\n",
> + __func__, env->exception_index, env->psw.addr);
>
> s390_add_running_cpu(env);
> /* handle external interrupts */
> diff --git a/target-s390x/misc_helper.c b/target-s390x/misc_helper.c
> index 2938ac9..e9b3cae 100644
> --- a/target-s390x/misc_helper.c
> +++ b/target-s390x/misc_helper.c
> @@ -53,7 +53,8 @@ void HELPER(exception)(CPUS390XState *env, uint32_t excp)
> #ifndef CONFIG_USER_ONLY
> void program_interrupt(CPUS390XState *env, uint32_t code, int ilc)
> {
> - qemu_log("program interrupt at %#" PRIx64 "\n", env->psw.addr);
> + qemu_log_mask(CPU_LOG_INT, "program interrupt at %#" PRIx64 "\n",
> + env->psw.addr);
>
> if (kvm_enabled()) {
> #ifdef CONFIG_KVM
> --
> 1.7.11.4
Reviewed-by: Aurelien Jarno <address@hidden>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH 0/7] Tidy -d op_opt,int,cpu, Richard Henderson, 2012/09/24
- [Qemu-devel] [PATCH 1/7] Emit debug_insn for CPU_LOG_TB_OP_OPT as well., Richard Henderson, 2012/09/24
- [Qemu-devel] [PATCH 2/7] target-m68k: Call tcg_gen_debug_insn_start, Richard Henderson, 2012/09/24
- [Qemu-devel] [PATCH 3/7] target-s390x: Call tcg_gen_debug_insn_start, Richard Henderson, 2012/09/24
- [Qemu-devel] [PATCH 4/7] target-unicore32: Call tcg_gen_debug_insn_start, Richard Henderson, 2012/09/24
- [Qemu-devel] [PATCH 5/7] target-s390x: Use CPU_LOG_INT, Richard Henderson, 2012/09/24
- Re: [Qemu-devel] [PATCH 5/7] target-s390x: Use CPU_LOG_INT,
Aurelien Jarno <=
- [Qemu-devel] [PATCH 6/7] target-s390x: Avoid double CPU_LOG_TB_CPU, Richard Henderson, 2012/09/24
- [Qemu-devel] [PATCH 7/7] target-s390x: Tidy cpu_dump_state, Richard Henderson, 2012/09/24
- Re: [Qemu-devel] [PATCH 0/7] Tidy -d op_opt,int,cpu, Alexander Graf, 2012/09/25
- Re: [Qemu-devel] [PATCH 0/7] Tidy -d op_opt,int,cpu, Aurelien Jarno, 2012/09/27