[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 13/14] virtio-net: test peer header support at init
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PATCH 13/14] virtio-net: test peer header support at init time |
Date: |
Tue, 25 Sep 2012 01:05:09 +0200 |
There's no reason to query header support at random
times: at load or feature query.
Driver also might not query functions.
Cleaner to do it at device init.
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/virtio-net.c | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/hw/virtio-net.c b/hw/virtio-net.c
index c65dead..a7c8bb3 100644
--- a/hw/virtio-net.c
+++ b/hw/virtio-net.c
@@ -202,16 +202,19 @@ static void virtio_net_reset(VirtIODevice *vdev)
memset(n->vlans, 0, MAX_VLAN >> 3);
}
-static int peer_has_vnet_hdr(VirtIONet *n)
+static void peer_test_vnet_hdr(VirtIONet *n)
{
if (!n->nic->nc.peer)
- return 0;
+ return;
if (n->nic->nc.peer->info->type != NET_CLIENT_OPTIONS_KIND_TAP)
- return 0;
+ return;
n->has_vnet_hdr = tap_has_vnet_hdr(n->nic->nc.peer);
+}
+static int peer_has_vnet_hdr(VirtIONet *n)
+{
return n->has_vnet_hdr;
}
@@ -231,10 +234,7 @@ static uint32_t virtio_net_get_features(VirtIODevice
*vdev, uint32_t features)
features |= (1 << VIRTIO_NET_F_MAC);
- if (peer_has_vnet_hdr(n)) {
- tap_using_vnet_hdr(n->nic->nc.peer, 1);
- n->host_hdr_len = sizeof(struct virtio_net_hdr);
- } else {
+ if (!peer_has_vnet_hdr(n)) {
features &= ~(0x1 << VIRTIO_NET_F_CSUM);
features &= ~(0x1 << VIRTIO_NET_F_HOST_TSO4);
features &= ~(0x1 << VIRTIO_NET_F_HOST_TSO6);
@@ -937,8 +937,6 @@ static int virtio_net_load(QEMUFile *f, void *opaque, int
version_id)
}
if (n->has_vnet_hdr) {
- tap_using_vnet_hdr(n->nic->nc.peer, 1);
- n->host_hdr_len = sizeof(struct virtio_net_hdr);
tap_set_offload(n->nic->nc.peer,
(n->vdev.guest_features >> VIRTIO_NET_F_GUEST_CSUM) & 1,
(n->vdev.guest_features >> VIRTIO_NET_F_GUEST_TSO4) & 1,
@@ -1032,6 +1030,13 @@ VirtIODevice *virtio_net_init(DeviceState *dev, NICConf
*conf,
n->status = VIRTIO_NET_S_LINK_UP;
n->nic = qemu_new_nic(&net_virtio_info, conf,
object_get_typename(OBJECT(dev)), dev->id, n);
+ peer_test_vnet_hdr(n);
+ if (peer_has_vnet_hdr(n)) {
+ tap_using_vnet_hdr(n->nic->nc.peer, 1);
+ n->host_hdr_len = sizeof(struct virtio_net_hdr);
+ } else {
+ n->host_hdr_len = 0;
+ }
qemu_format_nic_info_str(&n->nic->nc, conf->macaddr.a);
--
MST
- [Qemu-devel] [PATCH 08/14] virtio-net: switch tx to safe iov functions, (continued)
- [Qemu-devel] [PATCH 08/14] virtio-net: switch tx to safe iov functions, Michael S. Tsirkin, 2012/09/24
- [Qemu-devel] [PATCH 09/14] virtio-net: simplify rx code, Michael S. Tsirkin, 2012/09/24
- [Qemu-devel] [PATCH 06/14] virtio-net: refactor receive_hdr, Michael S. Tsirkin, 2012/09/24
- [Qemu-devel] [PATCH 10/14] virtio: don't mark unaccessed memory as dirty, Michael S. Tsirkin, 2012/09/24
- [Qemu-devel] [PATCH 11/14] virtio-net: fix used len for tx, Michael S. Tsirkin, 2012/09/24
- [Qemu-devel] [PATCH 12/14] virtio-net: minor code simplification, Michael S. Tsirkin, 2012/09/24
- [Qemu-devel] [PATCH 14/14] virtio-net: enable mrg buf header in tap on linux, Michael S. Tsirkin, 2012/09/24
- [Qemu-devel] [PATCH 13/14] virtio-net: test peer header support at init time,
Michael S. Tsirkin <=