Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga

[Blue Swirl]

On Thu, Sep 20, 2012 at 5:43 AM, Gerd Hoffmann <address@hidden> wrote:
>   Hi,
>
>>> +    vbe_ioport_write_index(&d->vga, 0, index);
>>> +    return vbe_ioport_read_data(&d->vga, 0);
>>
>> These functions are only available with CONFIG_BOCHS_VBE #defined, so
>> this code should be conditional as well.
>>
>> But building without CONFIG_BOCHS_VBE is not very useful since it's
>> used by the BIOS and there's no display output without it IIRC.
>
> Well, text mode is still there, but no (by modern standards) useful
> graphics modes, only standard vga ones (i.e. up to 800x600 @ 256 colors
> or something like that).
>
> I guess it is better to just remove CONFIG_BOCHS_VBE, /me goes prepare a
> patch.

Bochs support could be disabled with a property, but again the value
is probably low.

>
> cheers,
>   Gerd
>