[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 33/41] savevm: make qemu_fill_buffer() be consis
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 33/41] savevm: make qemu_fill_buffer() be consistent |
Date: |
Fri, 21 Sep 2012 14:48:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
Il 21/09/2012 10:47, Juan Quintela ha scritto:
> It was setting last_error directly once, and with the helper the other time.
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> savevm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/savevm.c b/savevm.c
> index 8ddb9d5..4e4aa3c 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -501,7 +501,7 @@ static void qemu_fill_buffer(QEMUFile *f)
> f->buf_size += len;
> f->buf_offset += len;
> } else if (len == 0) {
> - f->last_error = -EIO;
> + qemu_file_set_error(f, -EIO);
> } else if (len != -EAGAIN)
> qemu_file_set_error(f, len);
> }
>
Reviewed-by: Paolo Bonzini <address@hidden>
- Re: [Qemu-devel] [PATCH 38/41] block-migration: handle errors with the return codes correctly, (continued)
- [Qemu-devel] [PATCH 40/41] savevm: make qemu_file_put_notify() return errors, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 36/41] block-migration: make flush_blks() return errors, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 39/41] savevm: un-export qemu_file_set_error(), Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 25/41] buffered_file: make buffered_flush return the error code, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 33/41] savevm: make qemu_fill_buffer() be consistent, Juan Quintela, 2012/09/21
- Re: [Qemu-devel] [PATCH 33/41] savevm: make qemu_fill_buffer() be consistent,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 32/41] savevm: unexport qemu_ftell(), Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 31/41] savevm: unfold qemu_fclose_internal(), Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 28/41] virtio-net: use qemu_get_buffer() in a temp buffer, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 41/41] cpus: create qemu_cpu_is_vcpu(), Juan Quintela, 2012/09/21