[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 24/41] buffered_file: callers of buffered_flush(
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 24/41] buffered_file: callers of buffered_flush() already check for errors |
Date: |
Fri, 21 Sep 2012 14:39:55 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
Il 21/09/2012 10:47, Juan Quintela ha scritto:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> buffered_file.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/buffered_file.c b/buffered_file.c
> index 43e68b6..747d672 100644
> --- a/buffered_file.c
> +++ b/buffered_file.c
> @@ -61,13 +61,6 @@ static void buffered_append(QEMUFileBuffered *s,
> static void buffered_flush(QEMUFileBuffered *s)
> {
> size_t offset = 0;
> - int error;
> -
> - error = qemu_file_get_error(s->file);
> - if (error != 0) {
> - DPRINTF("flush when error, bailing: %s\n", strerror(-error));
> - return;
> - }
>
> DPRINTF("flushing %zu byte(s) of data\n", s->buffer_size);
>
Right, they do so _before_ checking buffered_flush which matches the
code you are removing here.
Perhaps an assertion would be better, but still:
Reviewed-by: Paolo Bonzini <address@hidden>
- Re: [Qemu-devel] [PATCH 41/41] cpus: create qemu_cpu_is_vcpu(), (continued)
[Qemu-devel] [PATCH 35/41] buffered_file: buffered_put_buffer() don't need to set last_error, Juan Quintela, 2012/09/21
[Qemu-devel] [PATCH 37/41] block-migration: Switch meaning of return value, Juan Quintela, 2012/09/21
[Qemu-devel] [PATCH 34/41] savevm: Only qemu_fflush() can generate errors, Juan Quintela, 2012/09/21
[Qemu-devel] [PATCH 24/41] buffered_file: callers of buffered_flush() already check for errors, Juan Quintela, 2012/09/21
- Re: [Qemu-devel] [PATCH 24/41] buffered_file: callers of buffered_flush() already check for errors,
Paolo Bonzini <=