[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 02/19] block: make bdrv_set_enable_write_cache()
From: |
Jeff Cody |
Subject: |
[Qemu-devel] [PATCH v4 02/19] block: make bdrv_set_enable_write_cache() modify open_flags |
Date: |
Thu, 20 Sep 2012 15:13:18 -0400 |
bdrv_set_enable_write_cache() sets the bs->enable_write_cache flag,
but without the flag recorded in bs->open_flags, then next time
a reopen() is performed the enable_write_cache setting may be
inadvertently lost.
This will set the flag in open_flags, so it is preserved across
reopens.
Signed-off-by: Jeff Cody <address@hidden>
---
block.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/block.c b/block.c
index 4c0e7f5..458bcc9 100644
--- a/block.c
+++ b/block.c
@@ -2168,6 +2168,13 @@ int bdrv_enable_write_cache(BlockDriverState *bs)
void bdrv_set_enable_write_cache(BlockDriverState *bs, bool wce)
{
bs->enable_write_cache = wce;
+
+ /* so a reopen() will preserve wce */
+ if (wce) {
+ bs->open_flags |= BDRV_O_CACHE_WB;
+ } else {
+ bs->open_flags &= ~BDRV_O_CACHE_WB;
+ }
}
int bdrv_is_encrypted(BlockDriverState *bs)
--
1.7.11.4
- [Qemu-devel] [PATCH v4 00/19] block: bdrv_reopen() patches, Jeff Cody, 2012/09/20
- [Qemu-devel] [PATCH v4 02/19] block: make bdrv_set_enable_write_cache() modify open_flags,
Jeff Cody <=
- [Qemu-devel] [PATCH v4 03/19] block: Framework for reopening files safely, Jeff Cody, 2012/09/20
- [Qemu-devel] [PATCH v4 04/19] block: move aio initialization into a helper function, Jeff Cody, 2012/09/20
- [Qemu-devel] [PATCH v4 01/19] block: correctly set the keep_read_only flag, Jeff Cody, 2012/09/20
- [Qemu-devel] [PATCH v4 06/19] block: do not parse BDRV_O_CACHE_WB in block drivers, Jeff Cody, 2012/09/20
- [Qemu-devel] [PATCH v4 07/19] block: use BDRV_O_NOCACHE instead of s->aligned_buf in raw-posix.c, Jeff Cody, 2012/09/20
- [Qemu-devel] [PATCH v4 05/19] block: move open flag parsing in raw block drivers to helper functions, Jeff Cody, 2012/09/20
- [Qemu-devel] [PATCH v4 09/19] block: raw-posix image file reopen, Jeff Cody, 2012/09/20
- [Qemu-devel] [PATCH v4 08/19] block: purge s->aligned_buf and s->aligned_buf_size from raw-posix.c, Jeff Cody, 2012/09/20
- [Qemu-devel] [PATCH v4 12/19] block: qcow2 image file reopen, Jeff Cody, 2012/09/20