[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qxl/update_area_io: cleanup invalid parameters
|
From: |
Michael Tokarev |
|
Subject: |
Re: [Qemu-devel] [PATCH] qxl/update_area_io: cleanup invalid parameters handling |
|
Date: |
Thu, 20 Sep 2012 10:43:26 +0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:10.0.6esrpre) Gecko/20120817 Icedove/10.0.6 |
On 20.09.2012 10:41, Gerd Hoffmann wrote:
> On 09/19/12 15:41, Michael Tokarev wrote:
>> This cleans up two additions of almost the same code in commits
>> 511b13e2c9 and ccc2960d654. While at it, make error paths
>> consistent (always use 'break' instead of 'return').
>
> Other way around: should be 'return' not 'break'.
In other, early-added, error-return places it is "break".
For now it is irrelevant actually, since right after the
switch we already have "return", so "break" is now the
same as "return". For future it might not be the case.
/mjt