[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 04/19] block: move aio initialization into a help
From: |
Jeff Cody |
Subject: |
[Qemu-devel] [PATCH v3 04/19] block: move aio initialization into a helper function |
Date: |
Tue, 18 Sep 2012 14:53:09 -0400 |
Move AIO initialization for raw-posix block driver into a helper function.
In addition to just code motion, the aio_ctx pointer is checked for NULL,
prior to calling laio_init(), to make sure laio_init() is only run once.
Signed-off-by: Jeff Cody <address@hidden>
---
block/raw-posix.c | 55 +++++++++++++++++++++++++++++++++++--------------------
1 file changed, 35 insertions(+), 20 deletions(-)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index 6be20b1..ee55f79 100644
--- a/block/raw-posix.c
+++ b/block/raw-posix.c
@@ -185,6 +185,40 @@ static int raw_normalize_devicepath(const char **filename)
}
#endif
+static int raw_set_aio(void **aio_ctx, int *use_aio, int bdrv_flags)
+{
+#ifdef CONFIG_LINUX_AIO
+ int ret = -1;
+ assert(aio_ctx != NULL);
+ assert(use_aio != NULL);
+ /*
+ * Currently Linux do AIO only for files opened with O_DIRECT
+ * specified so check NOCACHE flag too
+ */
+ if ((bdrv_flags & (BDRV_O_NOCACHE|BDRV_O_NATIVE_AIO)) ==
+ (BDRV_O_NOCACHE|BDRV_O_NATIVE_AIO)) {
+
+ /* if non-NULL, laio_init() has already been run */
+ if (*aio_ctx == NULL) {
+ *aio_ctx = laio_init();
+ if (!*aio_ctx) {
+ goto error;
+ }
+ }
+ *use_aio = 1;
+ } else {
+ *use_aio = 0;
+ }
+
+ ret = 0;
+
+error:
+ return ret;
+#else
+ return 0;
+#endif
+}
+
static int raw_open_common(BlockDriverState *bs, const char *filename,
int bdrv_flags, int open_flags)
{
@@ -239,26 +273,7 @@ static int raw_open_common(BlockDriverState *bs, const
char *filename,
goto out_free_buf;
}
-#ifdef CONFIG_LINUX_AIO
- /*
- * Currently Linux do AIO only for files opened with O_DIRECT
- * specified so check NOCACHE flag too
- */
- if ((bdrv_flags & (BDRV_O_NOCACHE|BDRV_O_NATIVE_AIO)) ==
- (BDRV_O_NOCACHE|BDRV_O_NATIVE_AIO)) {
-
- s->aio_ctx = laio_init();
- if (!s->aio_ctx) {
- goto out_free_buf;
- }
- s->use_aio = 1;
- } else
-#endif
- {
-#ifdef CONFIG_LINUX_AIO
- s->use_aio = 0;
-#endif
- }
+ raw_set_aio(&s->aio_ctx, &s->use_aio, bdrv_flags);
#ifdef CONFIG_XFS
if (platform_test_xfs_fd(s->fd)) {
--
1.7.11.4
- [Qemu-devel] [PATCH v3 00/19] block: bdrv_reopen() patches, Jeff Cody, 2012/09/18
- [Qemu-devel] [PATCH v3 04/19] block: move aio initialization into a helper function,
Jeff Cody <=
- [Qemu-devel] [PATCH v3 03/19] block: Framework for reopening files safely, Jeff Cody, 2012/09/18
- [Qemu-devel] [PATCH v3 05/19] block: move open flag parsing in raw block drivers to helper functions, Jeff Cody, 2012/09/18
- [Qemu-devel] [PATCH v3 06/19] block: do not parse BDRV_O_CACHE_WB in block drivers, Jeff Cody, 2012/09/18
- [Qemu-devel] [PATCH v3 07/19] block: use BDRV_O_NOCACHE instead of s->aligned_buf in raw-posix.c, Jeff Cody, 2012/09/18
- [Qemu-devel] [PATCH v3 09/19] block: raw-posix image file reopen, Jeff Cody, 2012/09/18