Re: [Qemu-devel] [PATCH] xtensa: Fix broken build (linker error)

[Jan Kiszka]

On 2012-09-17 22:14, Stefan Weil wrote:
> This configuration requires CONFIG_i8254:
> 
> configure --target-list=xtensa-softmmu --audio-card-list=pcspk

This is wrong. The pcspk "audio card" is registered automatically for
those targets that support it.

> 
> Reported-by: Vassili Karpov (malc) <address@hidden>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>  default-configs/xtensa-softmmu.mak   |    1 +
>  default-configs/xtensaeb-softmmu.mak |    1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/default-configs/xtensa-softmmu.mak 
> b/default-configs/xtensa-softmmu.mak
> index 9d8899c..c3a263b 100644
> --- a/default-configs/xtensa-softmmu.mak
> +++ b/default-configs/xtensa-softmmu.mak
> @@ -1,5 +1,6 @@
>  # Default configuration for Xtensa
>  
> +CONFIG_I8254=y

And this wrong as well. xtensa does not include any speaker, nor does it
include a PIT.

Jan

>  CONFIG_SERIAL=y
>  CONFIG_OPENCORES_ETH=y
>  CONFIG_PFLASH_CFI01=y
> diff --git a/default-configs/xtensaeb-softmmu.mak 
> b/default-configs/xtensaeb-softmmu.mak
> index 9d8899c..c3a263b 100644
> --- a/default-configs/xtensaeb-softmmu.mak
> +++ b/default-configs/xtensaeb-softmmu.mak
> @@ -1,5 +1,6 @@
>  # Default configuration for Xtensa
>  
> +CONFIG_I8254=y
>  CONFIG_SERIAL=y
>  CONFIG_OPENCORES_ETH=y
>  CONFIG_PFLASH_CFI01=y
>

signature.asc
Description: OpenPGP digital signature