Re: [Qemu-devel] [PATCH 04/13] tcg-sparc: Assume v9 cpu always, i.e. force v8plus in 32-bit mode.

[Andreas Färber]

Am 17.09.2012 17:28, schrieb Richard Henderson:
> Current code doesn't actually work in 32-bit mode at all.  Since
> no one really noticed, drop the complication of v7 and v8 cpus.
> Eliminate the --sparc_cpu configure option and standardize macro
> testing on TCG_TARGET_REG_BITS / HOST_LONG_BITS
> 
> Also, a bug fix: don't MAP_FIXED right on top of the program
> address space set in sparc64.ld.
> 
> Signed-off-by: Richard Henderson <address@hidden>

Without knowing the code, this does not strike me as the best of ideas:
SPARC CPUs are rather uncommon these days, so being able to emulate it
in sparc32-softmmu may be helpful for keeping it working.

Could you elaborate on what exactly is broken and what would need to be
done as alternative?

The MAP_FIXED bugfix (keyword "also") should probably go into its own
patch either way.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg