[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/8] qerror: new error for live block commit, QE
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 4/8] qerror: new error for live block commit, QERR_TOP_NOT_FOUND |
Date: |
Fri, 14 Sep 2012 10:01:31 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 |
On 09/14/2012 07:41 AM, Jeff Cody wrote:
> Signed-off-by: Jeff Cody <address@hidden>
> ---
> qerror.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/qerror.h b/qerror.h
> index d0a76a4..7396184 100644
> --- a/qerror.h
> +++ b/qerror.h
> @@ -219,6 +219,9 @@ void assert_no_error(Error *err);
> #define QERR_TOO_MANY_FILES \
> ERROR_CLASS_GENERIC_ERROR, "Too many open files"
>
> +#define QERR_TOP_NOT_FOUND \
> + ERROR_CLASS_GENERIC_ERROR, "Top image file %s not found"
> +
Is this patch really still needed, now that the generic error handling
is in? Shouldn't you instead be using error_setg() in patch 6/8 for the
one place that prints this error message?
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH 3/8] blockdev: rename block_stream_cb to a generic block_job_cb, Jeff Cody, 2012/09/14
[Qemu-devel] [PATCH 4/8] qerror: new error for live block commit, QERR_TOP_NOT_FOUND, Jeff Cody, 2012/09/14
- Re: [Qemu-devel] [PATCH 4/8] qerror: new error for live block commit, QERR_TOP_NOT_FOUND,
Eric Blake <=
[Qemu-devel] [PATCH 6/8] QAPI: add command for live block commit, 'block-commit', Jeff Cody, 2012/09/14
[Qemu-devel] [PATCH 8/8] block: after creating a live snapshot, make old image read-only, Jeff Cody, 2012/09/14
[Qemu-devel] [PATCH 1/8] block: add support functions for live commit, to find and delete images., Jeff Cody, 2012/09/14
[Qemu-devel] [PATCH 5/8] block: helper function, to find the base image of a chain, Jeff Cody, 2012/09/14
[Qemu-devel] [PATCH 7/8] qemu-iotests: add initial tests for live block commit, Jeff Cody, 2012/09/14