Re: [Qemu-devel] [PATCH v3 1/3] Refactor inet_connect_opts function

[Juan Quintela]

Orit Wasserman <address@hidden> wrote:
> From: "Michael S. Tsirkin" <address@hidden>
>
> refactor address resolution code to fix nonblocking connect
> remove getnameinfo call
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Amos Kong <address@hidden>
> Signed-off-by: Orit Wasserman <address@hidden>

Reviewed-by: Juan Quintela <address@hidden> 

> -int inet_connect_opts(QemuOpts *opts, bool *in_progress, Error **errp)
> +#ifdef _WIN32
> +#define QEMU_SOCKET_RC_INPROGRESS(rc) \
> +    ((rc) == -EINPROGRESS || rc == -EWOULDBLOCK || rc == -WSAEALREADY)
> +#else
> +#define QEMU_SOCKET_RC_INPROGRESS(rc) \
> +    ((rc) == -EINPROGRESS)
> +#endif

Not specific to this series, but this is used all around in qemu.
Should we put it into osdep.h and refactor?