[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 13/16] block: vmdk image file reopen
From: |
Jeff Cody |
Subject: |
[Qemu-devel] [PATCH v2 13/16] block: vmdk image file reopen |
Date: |
Thu, 13 Sep 2012 11:49:51 -0400 |
This patch supports reopen for VMDK image files. VMDK extents are added
to the existing reopen queue, so that the transactional model of reopen
is maintained with multiple image files.
Signed-off-by: Jeff Cody <address@hidden>
---
block/vmdk.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 47 insertions(+)
diff --git a/block/vmdk.c b/block/vmdk.c
index bba4c61..426dfc6 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -300,6 +300,50 @@ static int vmdk_is_cid_valid(BlockDriverState *bs)
return 1;
}
+/* Queue extents, if any, for reopen() */
+static int vmdk_reopen_prepare(BDRVReopenState *state, Error **errp)
+{
+ BDRVVmdkState *s;
+ int ret = -1;
+ int i;
+ VmdkExtent *e;
+
+ assert(state != NULL);
+ assert(state->bs != NULL);
+
+ if (state->queue == NULL) {
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR,
+ "No reopen queue for VMDK extents");
+ goto exit;
+ }
+
+ s = state->bs->opaque;
+
+ assert(s != NULL);
+
+ for (i = 0; i < s->num_extents; i++) {
+ e = &s->extents[i];
+ if (e->file != state->bs->file) {
+ bdrv_reopen_queue(state->queue, e->file, state->flags);
+ }
+ }
+ ret = 0;
+
+exit:
+ return ret;
+}
+
+/* No action for commit, or abort. All VMDK has to do is
+ * queue the extents for reopen */
+static void vmdk_reopen_commit(BDRVReopenState *state)
+{
+}
+
+static void vmdk_reopen_abort(BDRVReopenState *state)
+{
+}
+
+
static int vmdk_parent_open(BlockDriverState *bs)
{
char *p_name;
@@ -1646,6 +1690,9 @@ static BlockDriver bdrv_vmdk = {
.instance_size = sizeof(BDRVVmdkState),
.bdrv_probe = vmdk_probe,
.bdrv_open = vmdk_open,
+ .bdrv_reopen_prepare = vmdk_reopen_prepare,
+ .bdrv_reopen_commit = vmdk_reopen_commit,
+ .bdrv_reopen_abort = vmdk_reopen_abort,
.bdrv_read = vmdk_co_read,
.bdrv_write = vmdk_co_write,
.bdrv_close = vmdk_close,
--
1.7.11.4
- Re: [Qemu-devel] [PATCH v2 08/16] block: raw-posix image file reopen, (continued)
- [Qemu-devel] [PATCH v2 07/16] block: move allocating aligned_buf into a helper function in raw_posix.c, Jeff Cody, 2012/09/13
- [Qemu-devel] [PATCH v2 11/16] block: qcow2 image file reopen, Jeff Cody, 2012/09/13
- [Qemu-devel] [PATCH v2 16/16] block: remove keep_read_only flag from BlockDriverState struct, Jeff Cody, 2012/09/13
- [Qemu-devel] [PATCH v2 05/16] block: move open flag parsing in raw block drivers to helper functions, Jeff Cody, 2012/09/13
- [Qemu-devel] [PATCH v2 15/16] block: convert bdrv_commit() to use bdrv_reopen(), Jeff Cody, 2012/09/13
- [Qemu-devel] [PATCH v2 14/16] block: raw-win32 driver reopen support, Jeff Cody, 2012/09/13
- [Qemu-devel] [PATCH v2 12/16] block: qcow image file reopen, Jeff Cody, 2012/09/13
- [Qemu-devel] [PATCH v2 13/16] block: vmdk image file reopen,
Jeff Cody <=