[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command |
Date: |
Thu, 13 Sep 2012 15:26:37 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
Am 13.09.2012 15:24, schrieb Paolo Bonzini:
> Il 13/09/2012 15:15, Kevin Wolf ha scritto:
>>>> + flags = bs->open_flags | BDRV_O_RDWR;
>> Do we take care to make the image read-only again after completion?
>
> Not at the file-descriptor level, but bs->read_only is indeed restored
> to "true" via bdrv_swap.
>
> Doing it on the file descriptor is possible with Jeff's bdrv_reopen patches.
Ah, right, obviously you can't do it before Jeff's patches are in. But
yes, this is what I meant.
Kevin