[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 007/126] target-s390: Use TCG registers for FPR
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 007/126] target-s390: Use TCG registers for FPR |
Date: |
Mon, 10 Sep 2012 16:52:43 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Mon, Sep 10, 2012 at 07:45:04AM -0700, Richard Henderson wrote:
> On 09/10/2012 07:34 AM, Aurelien Jarno wrote:
> > If it is not possible to implement your FPR code using these functions,
> > we might want to add some more, but I really thing it's a bad idea to
> > have this code in the targets.
>
> I thought I got rid of all this in the various rebasing. Certainly it's
> all gone by the end of the patch series.
>
> In particular, the optimization that I was looking for is handled inside
> tcg_gen_deposit_i64, so there's no point in doing this in target code too.
>
> I'll make sure this is gone from the next revision.
Ok, I have to say the series being quite long, I haven't looked at it in
details. If they are gone at the end, it's pretty fine for me.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH 004/126] target-s390: Fix disassembly of cpsdr, (continued)
[Qemu-devel] [PATCH 003/126] target-s390: Disassemble more z10 and z196 opcodes, Richard Henderson, 2012/09/09
[Qemu-devel] [PATCH 007/126] target-s390: Use TCG registers for FPR, Richard Henderson, 2012/09/09
[Qemu-devel] [PATCH 009/126] target-s390: Split o ut disas_jcc, Richard Henderson, 2012/09/09
[Qemu-devel] [PATCH 011/126] target-s390: Convert ADD HALFWORD, Richard Henderson, 2012/09/09
[Qemu-devel] [PATCH 012/126] target-s390: Implement SUBTRACT HALFWORD, Richard Henderson, 2012/09/09
[Qemu-devel] [PATCH 013/126] target-s390: Implement ADD LOGICAL WITH SIGNED IMMEDIATE, Richard Henderson, 2012/09/09
[Qemu-devel] [PATCH 015/126] target-s390: Convert AND, OR, XOR, Richard Henderson, 2012/09/09
[Qemu-devel] [PATCH 018/126] target-s390: Convert LOAD ADDRESS, Richard Henderson, 2012/09/09
[Qemu-devel] [PATCH 017/126] target-s390: Convert LOAD, LOAD LOGICAL, Richard Henderson, 2012/09/09
[Qemu-devel] [PATCH 014/126] target-s390: Convert MULTIPLY, Richard Henderson, 2012/09/09
[Qemu-devel] [PATCH 010/126] target-s390: Reorg exception handling, Richard Henderson, 2012/09/09