[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] move CPU models from cpus-x86_64.conf to C
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] move CPU models from cpus-x86_64.conf to C |
Date: |
Mon, 10 Sep 2012 14:18:38 +0200 |
On Wed, 5 Sep 2012 17:41:10 -0300
Eduardo Habkost <address@hidden> wrote:
> Those models are maintained by QEMU and may require compatibility code
> to be added when making some changes. Keeping the data in the C source
> code should make it simpler to handle those details.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> sysconfigs/target/cpus-x86_64.conf | 129 +---------------------
> target-i386/cpu.c | 219
> +++++++++++++++++++++++++++++++++++++ 2 files changed, 220 insertions(+),
> 128 deletions(-)
>
> diff --git a/sysconfigs/target/cpus-x86_64.conf
> b/sysconfigs/target/cpus-x86_64.conf index cee0ea9..3902189 100644
> --- a/sysconfigs/target/cpus-x86_64.conf
> +++ b/sysconfigs/target/cpus-x86_64.conf
> @@ -1,128 +1 @@
> -# x86 CPU MODELS
> -
> -[cpudef]
> - name = "Conroe"
> - level = "2"
> - vendor = "GenuineIntel"
> - family = "6"
> - model = "2"
> - stepping = "3"
> - feature_edx = "sse2 sse fxsr mmx clflush pse36 pat cmov mca pge mtrr
> sep apic cx8 mce pae msr tsc pse de fpu"
> - feature_ecx = "ssse3 sse3"
> - extfeature_edx = "i64 xd syscall"
...
> + .ext2_features = CPUID_EXT2_LM | CPUID_EXT2_NX |
> CPUID_EXT2_SYSCALL,
Silent fix, replacing i64 with CPUID_EXT2_LM
looks like "i64" is mistake and never worked. In Intel & AMD cpuid guides
01.EDX[30] is reserved and what was probably meant/intended here is to use
80000001h.EDX[29] /* CPUID_EXT2_LM */
Perhaps patch that fixes it ought to go before this one.
- [Qemu-devel] [PATCH 0/7] x86 CPU patches that didn't get into 1.2, Eduardo Habkost, 2012/09/05
- [Qemu-devel] [PATCH 3/7] i386: add missing CPUID_* constants, Eduardo Habkost, 2012/09/05
- [Qemu-devel] [PATCH 1/7] target-i386: Fold -cpu ?cpuid, ?model output into -cpu help, drop ?dump, Eduardo Habkost, 2012/09/05
- [Qemu-devel] [PATCH 7/7] i386: kill cpudef config section support, Eduardo Habkost, 2012/09/05
- [Qemu-devel] [PATCH 4/7] move CPU models from cpus-x86_64.conf to C, Eduardo Habkost, 2012/09/05
- Re: [Qemu-devel] [PATCH 4/7] move CPU models from cpus-x86_64.conf to C,
Igor Mammedov <=
- Re: [Qemu-devel] [PATCH 4/7] move CPU models from cpus-x86_64.conf to C, Igor Mammedov, 2012/09/10
- Re: [Qemu-devel] [PATCH 4/7] move CPU models from cpus-x86_64.conf to C, Igor Mammedov, 2012/09/10
- Re: [Qemu-devel] [PATCH 4/7] move CPU models from cpus-x86_64.conf to C, Don Slutz, 2012/09/10
- Re: [Qemu-devel] [PATCH 4/7] move CPU models from cpus-x86_64.conf to C, Andreas Färber, 2012/09/10
- Re: [Qemu-devel] [PATCH 4/7] move CPU models from cpus-x86_64.conf to C, Eduardo Habkost, 2012/09/10
- Re: [Qemu-devel] [PATCH 4/7] move CPU models from cpus-x86_64.conf to C, Andreas Färber, 2012/09/10
- Re: [Qemu-devel] [PATCH 4/7] move CPU models from cpus-x86_64.conf to C, Eduardo Habkost, 2012/09/10
Re: [Qemu-devel] [PATCH 4/7] move CPU models from cpus-x86_64.conf to C, Igor Mammedov, 2012/09/10
[Qemu-devel] [PATCH 2/7] Drop cpu_list_id macro, Eduardo Habkost, 2012/09/05