[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu |
Date: |
Sun, 09 Sep 2012 18:42:29 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 |
On 09/07/2012 11:26 AM, Liu Sheng wrote:
> as readonly memory is support in kvm, this patch supports this feature
> in qemu, mainly pluging the memory region with KVM_MEM_READONLY flag
> to kvm.
>
> @@ -1607,10 +1623,19 @@ int kvm_cpu_exec(CPUArchState *env)
> break;
> case KVM_EXIT_MMIO:
> DPRINTF("handle_mmio\n");
> - cpu_physical_memory_rw(run->mmio.phys_addr,
> - run->mmio.data,
> - run->mmio.len,
> - run->mmio.is_write);
> + if (run->mmio.write_readonly_mem) {
> + fprintf(stderr, "Guest is writing readonly memory, "
> + "phys_addr: %llx, len:%x, data[0]:%c, skip it.\n",
> + run->mmio.phys_addr,
> + run->mmio.len,
> + run->mmio.data[0]);
> + } else {
> + cpu_physical_memory_rw(run->mmio.phys_addr,
> + run->mmio.data,
> + run->mmio.len,
> + run->mmio.is_write);
> + }
> +
> ret = 0;
I don't think this is needed. A cpu_physical_memory_rw() to a ROM ought
to be ignored (and btw, it may not be a ROM - it could be a ROM/Device,
in which case it ought not to be ignored).
--
error compiling committee.c: too many arguments to function
- Re: [Qemu-devel] [PATCH 2/3] update kvm related the head file from kernel, (continued)
- [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu, Liu Sheng, 2012/09/07
- Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu, Jan Kiszka, 2012/09/07
- Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu, Avi Kivity, 2012/09/09
- Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu, Jan Kiszka, 2012/09/10
- Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu, Kevin O'Connor, 2012/09/10
- Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu, Jan Kiszka, 2012/09/11
- Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu, Anthony Liguori, 2012/09/11
- Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu, Jan Kiszka, 2012/09/11
- Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu, Kevin O'Connor, 2012/09/11
Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu,
Avi Kivity <=