Re: [Qemu-devel] [PATCH 1/5] softfloat: fix float{32, 64}_muladd options

[Peter Maydell]

On 8 September 2012 22:40, Max Filippov <address@hidden> wrote:
> On Sun, Sep 9, 2012 at 1:12 AM, Aurelien Jarno <address@hidden> wrote:
>> float{32,64}_muladd takes an enum as a parameter, and not flags. It
>> means the parameter should be checked with == test instead of &.
>
> I've also stumbled upon this bug, have a patch for it in the xtensa tree.
> I guess that the interface was designed to allow combining these flags, why
> don't just make them independent:

Yes, the intent is that all these negations can be controlled
separately so that you can have operations which do more than
one of them. ARM doesn't use the negation options so this isn't
a "live" bug, but IIRC I did check various other architectures
and those do require various combinations of these negate flags.
So I think Max's patch is the correct one.

-- PMM