Re: [Qemu-devel] [RFC-v3 0/5] vhost-scsi: Add support for host virtualized target

[Michael S. Tsirkin]

On Fri, Sep 07, 2012 at 09:23:22AM +0300, Michael S. Tsirkin wrote:
> On Tue, Aug 21, 2012 at 08:52:06PM +0000, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger <address@hidden>
> > 
> > Hi folks,
> > 
> > This is the third RFC for vhost-scsi patches against mainline QEMU v1.1
> 
> I rebased on top of 1.2 and put this in my tree:
> git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git pci
> 
> Please check it out, meanwhile we'll see if anyone complains.

OK I will be the first :).
Looks like build *without* CONFIG_VHOST_SCSI
is broken now:
 LINK  sparc64-softmmu/qemu-system-sparc64
../hw/qdev-properties.o: In function `parse_vhost_scsi_dev':
/scm/qemu/hw/qdev-properties.c:706: undefined reference to
`find_vhost_scsi'
../hw/qdev-properties.o: In function `print_vhost_scsi_dev':
/scm/qemu/hw/qdev-properties.c:719: undefined reference to
`vhost_scsi_get_id'
../libhw64/vl.o: In function `vhost_scsi_init_func':
/scm/qemu/vl.c:1943: undefined reference to `vhost_scsi_add_opts'
hw/virtio-scsi.o: In function `virtio_scsi_set_status':
/scm/qemu/hw/virtio-scsi.c:733: undefined reference to `vhost_scsi_stop'
/scm/qemu/hw/virtio-scsi.c:724: undefined reference to
`vhost_scsi_start'

Please add stubs *and test* without CONFIG_VHOST_SCSI.

While at it can we please rename file to vhost_scsi.c, vhost_scsi.h?
qemu is inconsistent but vhost files all use _ as separator:
this means function names and file names are in sync.

Reverted for now, waiting for v4.
Thanks!

> -- 
> MST