Re: [Qemu-devel] [PATCH] target-i386: Allow changing of Hypervisor CPUIDs.

[Eduardo Habkost]

On Thu, Sep 06, 2012 at 12:28:05PM +0200, Andreas Färber wrote:
> Am 30.08.2012 21:20, schrieb Don Slutz:
> > This is primarily done so that the guest will think it is running
> > under vmware when hypervisor=vmware is specified as a property of a
> > cpu.
> > 
> > Also allow this to work in accel=tcg mode.
> > 
> > The new cpu properties hyper_level, hyper_extra, hyper_extra_a, and
> > hyper_extra_b can be used to further adjust what the guest sees.
> > 
> > Signed-off-by: Don Slutz <address@hidden>
> > ---
> >  target-i386/cpu.c |  178 
> > +++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  target-i386/cpu.h |    9 +++
> >  target-i386/kvm.c |   33 ++++++++--
> >  3 files changed, 214 insertions(+), 6 deletions(-)
> 
> Please don't add new CPU command line options without matching QOM
> properties. There are patch series in the works that convert the CPU
> definitions to QOM subclasses, the parameters then need to be set on the
> X86CPU object instance.

It seems to be a good idea to wait for the CPU properties series from
Igor to be applied, before implementing this. It should make the new
code much simpler.

> 
> Note that the convention for QOM properties is
> descriptive-name-with-dashes rather than shortened_abbrev_with_underscore.
> 

-- 
Eduardo