qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] usb: Fix host-side endian bugs in hcd-ehci


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH] usb: Fix host-side endian bugs in hcd-ehci
Date: Thu, 06 Sep 2012 11:53:15 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.7) Gecko/20120825 Thunderbird/10.0.7

On 08/22/12 05:04, David Gibson wrote:
> The EHCI device model is horribly broken for big-endian hosts.  It uses a
> union of 'mmio' a byte array which is as-is as the device's MMIO space
> with the various internal registers.  The IO routines assume that mmio is
> laid out in little-endian order, but everything else in the code accesses
> the register variables directly assuming (host) native endian.
> 
> This fix is fairly ugly - a nicer approach would involve converting
> hcd-ehci to use the new-style memory region .read and .write functions -
> but it's the most minimal fix I can see to apply for the qemu 1.2 release.

Oops.  This one slipped through.  Just found it -- to late for 1.2 --
while wading through my inbox looking for unprocessed stuff.

Doing the real thing instead (i.e. convert memory regions) doesn't look
that horrible though, I think we can put that into stable-1.2.  I'll
send out the patch in a few moments.

cheers,
  Gerd



reply via email to

[Prev in Thread] Current Thread [Next in Thread]