[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] gtk: add support for input grabbing (v2)
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] gtk: add support for input grabbing (v2) |
Date: |
Wed, 05 Sep 2012 22:43:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-09-05 22:40, Anthony Liguori wrote:
> Jan Kiszka <address@hidden> writes:
>
>> On 2012-09-05 21:18, Anthony Liguori wrote:
>>> There is a small deviation from SDL's behavior here. Instead of Ctrl+Alt
>>> triggering grab, we now use Ctrl-Alt-g to trigger grab.
>>>
>>> GTK will not accept Ctrl+Alt as an accelerator since it just consists of
>>> modifiers. Having grab as a proper accelerator is important as it allows a
>>> user
>>> to override the accelerator for accessibility purposes.
>>>
>>> We also are not automatically grabbing on left-click. Besides the
>>> inability to
>>> tie mouse clicks to an accelerator, I think this behavior is hard to
>>> discover
>>> and since it only happens depending on the guest state, it can lead to
>>> confusing
>>> behavior.
>>>
>>> This can be changed in the future if there's a strong resistence to dropping
>>> left-click-to-grab, but I think we're better off dropping it.
>>>
>>> Signed-off-by: Anthony Liguori <address@hidden>
>>> ---
>>> v1 -> v2
>>> - add a menu option for grab on hover (Jan)
>>
>> Thanks. Are options like this persistent across VM starts?
>
> No. I don't want to include that in this series as it opens up a whole
> debate about GConf vs. configuration files...
Well, but it must be solved. In a later series, that's fine.
Jan
signature.asc
Description: OpenPGP digital signature