[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] block: Don't forget to del ete temporary file
From: |
riegamaths |
Subject: |
[Qemu-devel] [PATCH] block: Don't forget to del ete temporary file |
Date: |
Wed, 5 Sep 2012 21:26:22 +0800 |
From: Dunrong Huang <address@hidden>
The caller would not delete temporary file after failed get_tmp_filename().
Signed-off-by: Dunrong Huang <address@hidden>
---
block.c | 6 +++++-
1 个文件被修改,插入 5 行(+),删除 1 行(-)
diff --git a/block.c b/block.c
index 074987e..2bc9f75 100644
--- a/block.c
+++ b/block.c
@@ -433,7 +433,11 @@ int get_tmp_filename(char *filename, int size)
return -EOVERFLOW;
}
fd = mkstemp(filename);
- if (fd < 0 || close(fd)) {
+ if (fd < 0) {
+ return -errno;
+ }
+ if (close(fd) != 0) {
+ unlink(filename);
return -errno;
}
return 0;
--
1.7.12
- [Qemu-devel] [PATCH] block: Don't forget to del ete temporary file,
riegamaths <=
Re: [Qemu-devel] [PATCH] block: Don't forget to delete temporary file, Kevin Wolf, 2012/09/11