Re: [Qemu-devel] [PATCH] CHECKPATCH

[Blue Swirl]

On Sat, Sep 1, 2012 at 3:57 PM, Don Slutz <address@hidden> wrote:
> I took my best guess as to how to handle tabs and long lines in
> checkpatch.pl itself.

Right, it was taken from Linux without much change.

>
> So I get:
> ...
> total: 0 errors, 7 warnings, 131 lines checked
>
> I also did not figure out how to run a more complete test of the
> change.  Any pointers as to how would be helpful.

I've used the following snippet to check what happens with the last 100 commits:
for i in '' 1 2 3 4 5 6 7 8 9; do for j in 0 1 2 3 4 5 6 7 8 9; do
echo $i$j; git show HEAD~$i$j >/tmp/a; clear;head -20 /tmp/a;
./scripts/checkpatch.pl --root=. /tmp/a; read foo; done; done

Sadly, it also shows how much stuff gets committed without checking,
and on the other hand, the amount of false alarms.

>
>
> Don Slutz (1):
>   CHECKPATCH: Add warning for single else statement.
>
>  scripts/checkpatch.pl |   72 ++++++++++++++++++++++++++++++++----------------
>  1 files changed, 48 insertions(+), 24 deletions(-)
>