[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] introduce powerdown_notifiers
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/5] introduce powerdown_notifiers |
|
Date: |
Thu, 30 Aug 2012 09:41:55 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
Il 30/08/2012 08:49, Igor Mammedov ha scritto:
>>> > > +static void qemu_system_powerdown(void)
> this is a bad naming that conflicts with global var qemu_system_powerdown, so
> bisectability of series is still broken.
> perhaps qemu_do_system_powerdown() would be better for function name,
> although it doesn't match common name pattern used for this kind of functions.
>
Just inline the function in this patch, and uninline it later.
Paolo
- [Qemu-devel] [PATCH 0/5 v2] convert system_powerdown command to notifiers, Igor Mammedov, 2012/08/29
- [Qemu-devel] [PATCH 2/5] acpi: use notifier for signaling guest system_powerdown command, Igor Mammedov, 2012/08/29
- [Qemu-devel] [PATCH 3/5] target-arm: use notifier for signaling guest system_powerdown command, Igor Mammedov, 2012/08/29
- [Qemu-devel] [PATCH 4/5] target-sparc: use notifier for signaling guest system_powerdown command, Igor Mammedov, 2012/08/29
- [Qemu-devel] [PATCH 5/5] cleanup unused qemu_system_powerdown, Igor Mammedov, 2012/08/29
- [Qemu-devel] [PATCH 1/5] introduce powerdown_notifiers, Igor Mammedov, 2012/08/29