Re: [Qemu-devel] [PATCH V6 0/2] Add JSON output to qemu-img info

[Eric Blake]

On 08/27/2012 01:15 AM, Benoît Canet wrote:
> This patchset add a JSON output mode to the qemu-img info command.
> It's a rewrite from scratch of the original patchset by Wenchao Xia
> following Anthony Liguori advices on JSON formating.
> 
> the --output=(json|human) option is now mandatory on the command line.

This statement is not true, but doesn't affect the series itself.

> in v6:
> 
> Blue Swirl: -Add missing const in getopt structure declaration.
> 
> Eric Blake: -Remove spurious undef.
>             -Use an enum instead of two boolean.

You have now addressed my complaints about the interface, but I would
feel comfortable if someone more familiar with qemu-img itself gives
final review and/or ack.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature