[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] kvm-all.c: Move init of irqchip_inject_ioctl
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH v2] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create() |
Date: |
Tue, 21 Aug 2012 12:27:51 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-08-21 10:25, Peter Maydell wrote:
> On 21 August 2012 09:19, Jan Kiszka <address@hidden> wrote:
>> On 2012-08-15 13:08, Peter Maydell wrote:
>>> Move the init of the irqchip_inject_ioctl field of KVMState out of
>>> kvm_irqchip_create() and into kvm_init(), so that kvm_set_irq()
>>> can be used even when no irqchip is created (for architectures
>>> that support async interrupt notification even without an in
>>> kernel irqchip).
>
>> As it's not yet merged, some late comment: irqchip_inject_ioctl should
>> be renamed as well. irq_inject_ioctl?
>
> If we're changing it anyway, IIRC Avi didn't like the term "inject"
> here?
Then irq_set_ioctl.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux