[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] cpu: make a child of DeviceState
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] cpu: make a child of DeviceState |
Date: |
Wed, 15 Aug 2012 17:50:02 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 |
Am 10.08.2012 19:00, schrieb Anthony Liguori:
> This is just a rebase of this series that I posted back in June.
>
> Andreas had a different approach involving a #define but I think doing a full
> split ends up being nicer. For instance, the recently added thread
> information
> is only relevant to cpu-softmmu so we can limit that entirely to cpu-softmmu.
For the record, the thread information was not really added, it was
merely moved from CPU_COMMON, which being a large macro didn't easily
allow #ifdef'ing within itself (cf., former CPU_COMMON_THREAD).
If this were the only issue, we could add an #ifndef CONFIG_USER_ONLY to
drop unneeded CPU_COMMON fields - most CPU_COMMON fields are to
eventually end up in CPUState, so this discussion is not just about the
two(?) fields we see today.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg