Re: [Qemu-devel] [PATCH 0/7] qapi: add commands to remove the need (v2)

[Stefan Weil]

Am 13.08.2012 19:16, schrieb Luiz Capitulino:
> On Fri, 10 Aug 2012 11:04:08 -0500
> Anthony Liguori <address@hidden> wrote:
>
> > This series implements the necessary commands to implements danpb's idea to
> > remove -help parsing in libvirt.  We would introduce all of these commands in
> > 1.2 and then change the -help output starting in 1.3.
>
> Applied to the qmp branch, thanks.


The series breaks cross compilation of QEMU for w32 on Debian Linux:

  LINK  arm-softmmu/qemu-system-armw.exe
../qmp-marshal.o: In function `qmp_marshal_input_query_cpu_definitions':
/home/stefan/w32/qmp-marshal.c:2585: undefined reference to 
`_qmp_query_cpu_definitions'

Weak symbols obviously use a different name mangling, therefore 
qmp_query_cpu_definitions
is not found by the linker.

Adding GCC_WEAK to the declaration of qmp_query_cpu_definitions in 
generated file
qmp-commands.h fixes that.

Regards,

Stefan Weil