Re: [Qemu-devel] [PATCH for-1.2 0/3] prep: QOM'ify Super I/O

[Alexander Graf]

On 15.08.2012, at 16:24, Andreas Färber wrote:

> Hello,
> 
> This mini-series updates a patch by Hervé (that didn't make it into v1.1)
> to clean up the PReP device emulation and allowing it to be shared with a
> future 40P machine.
> 
> History: Hervé was original author of the 40P patches and provided them to me,
> I sent up to v5 (issue: ISABus not being hotplug-capable),
> then Hervé sent up to v2, so
> this is actually v8. ;)
> 
> For v1.1 I deferred Hervé's v1 due to a hack wrt NULL chr handlers in initfn.
> v2 moved the logic from the machine into the device, avoiding this for now.
> This version of mine fixes an error in case of no -serial options through use
> of qemu_chr_new() and applies some more QOM sugar and adds a header.
> 
> Prepended is a fix requested by Markus to allow using the -M prep machine
> with qemu-system-ppc64 (it would conflict with the changes here if sent 
> alone).
> 
> Since this only affects the PReP machine and has mostly been around for a 
> while,
> I feel this is still acceptable for v1.2 at this late stage unless Alex 
> objects.

No objections. You might want to send a pull request rather than a patch set 
though :).


Alex