[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: Don't override user's --cpu on MacOS
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH] configure: Don't override user's --cpu on MacOS and Solaris |
|
Date: |
Tue, 14 Aug 2012 16:51:55 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 |
Am 14.08.2012 16:35, schrieb Peter Maydell:
> Both MacOS and Solaris have special case handling for the CPU
> type, because the check_define probes will return i386 even if
> the hardware is 64 bit and x86_64 would be preferable. Move
> these checks earlier in the configure probing so that we can
> do them only if the user didn't specify a CPU with --cpu. This
> fixes a bug where the user's command line argument was being
> ignored.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> The per-OS checks are broken for cross compilation, but this isn't
> a change introduced by this patch -- they were broken before; I've
> merely added a comment noting the fact and the workaround...
Reviewed-by: Andreas Färber <address@hidden>
Looks okay as far as I can see. We should probably do the __APPLE__ ->
Darwin dance as a followup (ignoring the iOS, which can't JIT).
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg