[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 31/48] error: drop error_get_qobject()/error_set_qob
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 31/48] error: drop error_get_qobject()/error_set_qobject() |
Date: |
Mon, 13 Aug 2012 16:48:52 -0300 |
error_get_qobject() is unused since last commit, error_set_qobject()
has never been used. Also drops error_int.h.
Signed-off-by: Luiz Capitulino <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
---
error.c | 20 --------------------
error_int.h | 28 ----------------------------
qapi/qmp-dispatch.c | 1 -
qemu-ga.c | 1 -
4 files changed, 50 deletions(-)
delete mode 100644 error_int.h
diff --git a/error.c b/error.c
index b1d5131..9d7b35f 100644
--- a/error.c
+++ b/error.c
@@ -15,7 +15,6 @@
#include "qjson.h"
#include "qdict.h"
#include "qapi-types.h"
-#include "error_int.h"
#include "qerror.h"
struct Error
@@ -91,22 +90,3 @@ void error_propagate(Error **dst_err, Error *local_err)
error_free(local_err);
}
}
-
-QObject *error_get_qobject(Error *err)
-{
- QINCREF(err->obj);
- return QOBJECT(err->obj);
-}
-
-void error_set_qobject(Error **errp, QObject *obj)
-{
- Error *err;
- if (errp == NULL) {
- return;
- }
- err = g_malloc0(sizeof(*err));
- err->obj = qobject_to_qdict(obj);
- qobject_incref(obj);
-
- *errp = err;
-}
diff --git a/error_int.h b/error_int.h
deleted file mode 100644
index 4b00d08..0000000
--- a/error_int.h
+++ /dev/null
@@ -1,28 +0,0 @@
-/*
- * QEMU Error Objects
- *
- * Copyright IBM, Corp. 2011
- *
- * Authors:
- * Anthony Liguori <address@hidden>
- *
- * This work is licensed under the terms of the GNU LGPL, version 2. See
- * the COPYING.LIB file in the top-level directory.
- */
-#ifndef QEMU_ERROR_INT_H
-#define QEMU_ERROR_INT_H
-
-#include "qemu-common.h"
-#include "qobject.h"
-#include "qdict.h"
-#include "error.h"
-
-/**
- * Internal QEMU functions for working with Error.
- *
- * These are used to convert QErrors to Errors
- */
-QObject *error_get_qobject(Error *err);
-void error_set_qobject(Error **errp, QObject *obj);
-
-#endif
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
index ec613f8..4085994 100644
--- a/qapi/qmp-dispatch.c
+++ b/qapi/qmp-dispatch.c
@@ -16,7 +16,6 @@
#include "json-parser.h"
#include "qapi-types.h"
#include "error.h"
-#include "error_int.h"
#include "qerror.h"
static QDict *qmp_dispatch_check_obj(const QObject *request, Error **errp)
diff --git a/qemu-ga.c b/qemu-ga.c
index 39abc50..8f87621 100644
--- a/qemu-ga.c
+++ b/qemu-ga.c
@@ -28,7 +28,6 @@
#include "module.h"
#include "signal.h"
#include "qerror.h"
-#include "error_int.h"
#include "qapi/qmp-core.h"
#include "qga/channel.h"
#ifdef _WIN32
--
1.7.11.2.249.g31c7954.dirty
- [Qemu-devel] [PATCH 37/48] qmp: don't emit the RESET event on wakeup from S3, (continued)
- [Qemu-devel] [PATCH 37/48] qmp: don't emit the RESET event on wakeup from S3, Luiz Capitulino, 2012/08/13
- [Qemu-devel] [PATCH 42/48] qmp: introduce device-list-properties command, Luiz Capitulino, 2012/08/13
- [Qemu-devel] [PATCH 43/48] qapi: mark QOM commands stable, Luiz Capitulino, 2012/08/13
- [Qemu-devel] [PATCH 26/48] error: add error_get_class(), Luiz Capitulino, 2012/08/13
- [Qemu-devel] [PATCH 29/48] qmp: switch to the new error format on the wire, Luiz Capitulino, 2012/08/13
- [Qemu-devel] [PATCH 21/48] qapi: don't convert enum strings to lowercase, Luiz Capitulino, 2012/08/13
- [Qemu-devel] [PATCH 25/48] qerror: add proper ErrorClass value for QERR_ macros, Luiz Capitulino, 2012/08/13
- [Qemu-devel] [PATCH 48/48] target-ppc: add implementation of query-cpu-definitions (v2), Luiz Capitulino, 2012/08/13
- [Qemu-devel] [PATCH 24/48] error, qerror: add ErrorClass argument to error functions, Luiz Capitulino, 2012/08/13
- [Qemu-devel] [PATCH 47/48] target-i386: add implementation of query-cpu-definitions (v2), Luiz Capitulino, 2012/08/13
- [Qemu-devel] [PATCH 31/48] error: drop error_get_qobject()/error_set_qobject(),
Luiz Capitulino <=
- [Qemu-devel] [PATCH 27/48] hmp: hmp_change(): use error_get_class(), Luiz Capitulino, 2012/08/13
- [Qemu-devel] [PATCH 30/48] qemu-ga: switch to the new error format on the wire, Luiz Capitulino, 2012/08/13
- [Qemu-devel] [PATCH 41/48] qmp: add SUSPEND_DISK event, Luiz Capitulino, 2012/08/13
- [Qemu-devel] [PATCH 23/48] qerror: qerror_table: don't use C99 struct initializers, Luiz Capitulino, 2012/08/13
- [Qemu-devel] [PATCH 46/48] qapi: add query-cpu-definitions command (v2), Luiz Capitulino, 2012/08/13
- [Qemu-devel] [PATCH 39/48] qmp: qmp-events.txt: put events in alphabetical order, Luiz Capitulino, 2012/08/13
- [Qemu-devel] [PATCH 40/48] qmp: qmp-events.txt: add missing doc for the SUSPEND event, Luiz Capitulino, 2012/08/13
- [Qemu-devel] [PATCH 32/48] error, qerror: pass desc string to error calls, Luiz Capitulino, 2012/08/13
- [Qemu-devel] [PATCH 45/48] compiler: add macro for GCC weak symbols, Luiz Capitulino, 2012/08/13
- [Qemu-devel] [PATCH 44/48] qapi: add query-machines command, Luiz Capitulino, 2012/08/13