[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/7] migration: Add dirty_pages_rate to query mi
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 7/7] migration: Add dirty_pages_rate to query migrate output |
Date: |
Mon, 13 Aug 2012 09:12:01 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
On 08/13/2012 04:50 AM, Juan Quintela wrote:
> For now this is a placeholder, real info will appear once the bitmap
> changes in the migration thread series is integrated.
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> hmp.c | 4 ++++
> migration.c | 2 ++
> migration.h | 1 +
> qapi-schema.json | 6 +++++-
> 4 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/hmp.c b/hmp.c
> index fc75ec3..dd40631 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -174,6 +174,10 @@ void hmp_info_migrate(Monitor *mon)
> info->ram->normal);
> monitor_printf(mon, "normal bytes: %" PRIu64 " kbytes\n",
> info->ram->normal_bytes >> 10);
> + if (info->ram->dirty_pages_rate) {
> + monitor_printf(mon, "dirty pages rate: %" PRIu64 " pagfes\n",
s/pagfes/pages/
> +++ b/qapi-schema.json
> @@ -266,11 +266,15 @@
> #
> # @normal-bytes : number of normal bytes sent (since 1.2)
As long as you are touching here: s/ :/:/
> #
> +# @dirty-pages-rate: number of pages dirtied by second by the
> +# guest. (since 1.2)
Inconsistent on whether we have a '.' prior to the (since 1.2) marking.
Since HMP only prints this stat when it is non-zero, should this field
be marked optional? Then again, once you have dirty page tracking, I
suspect this would never be zero (or even showing an explicit zero would
help detect stalls).
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature