[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC 20/20] target-i386: move default init of cpuid_kvm_fea
From: |
Igor Mammedov |
Subject: |
[Qemu-devel] [RFC 20/20] target-i386: move default init of cpuid_kvm_features bitmap into CPU initializer from cpudef |
Date: |
Fri, 10 Aug 2012 13:22:36 +0200 |
Moving it inside CPU initializer from cpudef will help to split
cpu_x86_find_by_name() into default init and user settable properties.
PS:
Is kvm_features field necessary in cpudef, what the point
if it's almost imediately overwritten to ~0? Could it be removed
from cpudef?
Signed-off-by: Igor Mammedov <address@hidden>
---
target-i386/cpu.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 43601a3..e266792 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1093,6 +1093,9 @@ static void cpudef_2_x86_cpu(X86CPU *cpu, x86_def_t *def,
Error **errp)
env->cpuid_7_0_ebx = def->cpuid_7_0_ebx_features;
env->cpuid_xlevel2 = def->xlevel2;
+ /* not supported bits will be filtered out later */
+ env->cpuid_kvm_features = ~0;
+
object_property_set_bool(OBJECT(cpu), true, "hypervisor", errp);
}
@@ -1175,9 +1178,6 @@ static int cpu_x86_find_by_name(X86CPU *cpu, x86_def_t
*x86_cpu_def,
cpudef_2_x86_cpu(cpu, def, errp);
- /* not supported bits will be filtered out later */
- env->cpuid_kvm_features = ~0;
-
for (ent = qdict_first(features); ent; ent = qdict_next(features, ent)) {
const QString *qval = qobject_to_qstring(qdict_entry_value(ent));
object_property_parse(OBJECT(cpu), qstring_get_str(qval),
--
1.7.11.2
- Re: [Qemu-devel] [RFC 11/20] target-i386: convert 'check' and 'enforce' features into properties, (continued)
[Qemu-devel] [RFC 10/20] target-i386: convert 'hv_vapic' feature into property, Igor Mammedov, 2012/08/10
[Qemu-devel] [RFC 12/20] add visitor for parsing hz[KMG] input string, Igor Mammedov, 2012/08/10
[Qemu-devel] [RFC 16/20] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t, Igor Mammedov, 2012/08/10
[Qemu-devel] [RFC 17/20] target-i386: parse cpu_model string into set of stringified properties, Igor Mammedov, 2012/08/10
[Qemu-devel] [RFC 20/20] target-i386: move default init of cpuid_kvm_features bitmap into CPU initializer from cpudef,
Igor Mammedov <=
Re: [Qemu-devel] [RFC 00/20] target-i386: convert CPU features into properties, Igor Mammedov, 2012/08/10
[Qemu-devel] [RFC 19/20] target-i386: move init of "hypervisor" feature into CPU initializer from cpudef, Igor Mammedov, 2012/08/10
[Qemu-devel] [RFC 13/20] target-i386: use visit_type_hz to parse tsc_freq property value, Igor Mammedov, 2012/08/10
[Qemu-devel] [RFC 14/20] target-i386: introduce vendor-override property, Igor Mammedov, 2012/08/10
[Qemu-devel] [RFC 18/20] target-i386: use properties to set/unset user specified features on CPU, Igor Mammedov, 2012/08/10