Re: [Qemu-devel] [PATCH v5 09/15] hw: Added generic FIFO API.

[Peter Crosthwaite]

>> +
>> +extern const VMStateDescription vmstate_fifo8;
>> +
>> +#define VMSTATE_FIFO8(_field, _state) {                              \
>> +    .name       = (stringify(_field)),                               \
>> +    .size       = sizeof(Fifo8),                                     \
>> +    .vmsd       = &vmstate_fifo8,                                    \
>> +    .flags      = VMS_STRUCT,                                        \
>> +    .offset     = vmstate_offset_value(_state, _field, Fifo8),       \
>> +}
>
>
> how about implementing this as a wrapper to VMSTATE_STRUCT_TEST() macro
> instead?

This has no existing precedent in QEMU so I am unsure of what you mean?

And maybe this should go to vmstate.h header

I disagree. All other clients of VMS_STRUCT are out in their repective
device specific headers (pci.h, i2c.h) etc. Unless this is new
established policy, I dont really want to change the current adopted
approach.

Regards,
Peter

>
>
>> +
>> +#endif /* FIFO_H */
>
>