Re: [Qemu-devel] [PATCH 08/12] Add migrate_set_cache_size command

[Orit Wasserman]

On 08/06/2012 09:13 PM, Eric Blake wrote:
> On 08/06/2012 11:51 AM, Orit Wasserman wrote:
>> Change XBZRLE cache size in bytes (the size should be a power of 2, it will 
>> be
>> rounded down to the nearest power of 2).
>> If XBZRLE cache size is too small there will be many cache miss.
>>
>> New query-migrate-cache-size QMP command and 'info migrate_cache_size' HMP
>> command to query cache value.
>>
>> Signed-off-by: Benoit Hudzia <address@hidden>
>> Signed-off-by: Petter Svard <address@hidden>
>> Signed-off-by: Aidan Shribman <address@hidden>
>> Signed-off-by: Orit Wasserman <address@hidden>
> 
>> +#
>> +# Since: 1.2
>> +##
>> +{ 'command': 'query-migrate-cache-size', 'returns': 'int' }
> 
> This is the first 'returns':'int' in the schema, but we do have a
> 'returns':'str' for comparison of returning a native type instead of a
> further struct.
> 
>> +Example:
>> +
>> +-> { "execute": "query-migrate-cache-size" }
>> +<- { "return": { "67108864" } }
> 
> Invalid JSON.  Inside an {}, everything has to be in name:value pairs,
> but you gave no name to your string.  But given the above, you aren't
> returning a string, but an int.  I think this should be:
> 
> { "return": 67108864 }
> 
> That's based solely off my reading of the schema, and not of the code
> itself, so please actually execute your code, to see what really came
> over the wire.
> 
you are right I will fix the example.

Orit