[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 08/10] alpha-linux-user: Fix a3 error return with v0
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH 08/10] alpha-linux-user: Fix a3 error return with v0 error bypass. |
Date: |
Fri, 3 Aug 2012 15:40:55 -0700 |
We were failing to initialize a3 for syscalls that bypass the
negative return value error check.
Signed-off-by: Richard Henderson <address@hidden>
---
linux-user/main.c | 12 +++++-------
1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/linux-user/main.c b/linux-user/main.c
index a21942c..53714de 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -2846,13 +2846,11 @@ void cpu_loop(CPUAlphaState *env)
break;
}
/* Syscall writes 0 to V0 to bypass error check, similar
- to how this is handled internal to Linux kernel. */
- if (env->ir[IR_V0] == 0) {
- env->ir[IR_V0] = sysret;
- } else {
- env->ir[IR_V0] = (sysret < 0 ? -sysret : sysret);
- env->ir[IR_A3] = (sysret < 0);
- }
+ to how this is handled internal to Linux kernel.
+ (Ab)use trapnr temporarily as boolean indicating error. */
+ trapnr = (env->ir[IR_V0] != 0 && sysret < 0);
+ env->ir[IR_V0] = (trapnr ? -sysret : sysret);
+ env->ir[IR_A3] = trapnr;
break;
case 0x86:
/* IMB */
--
1.7.7.6
- [Qemu-devel] [PATCH v5 00/10] {alpha-}linux user improvements, Richard Henderson, 2012/08/03
- [Qemu-devel] [PATCH 01/10] alpha-linux-user: Fix signal handling, Richard Henderson, 2012/08/03
- [Qemu-devel] [PATCH 02/10] alpha-linux-user: Work around hosted mmap allocation problems, Richard Henderson, 2012/08/03
- [Qemu-devel] [PATCH 03/10] alpha-linux-user: Handle TARGET_SSI_IEEE_RAISE_EXCEPTION properly, Richard Henderson, 2012/08/03
- [Qemu-devel] [PATCH 05/10] linux-user: Handle O_SYNC, O_NOATIME, O_CLOEXEC, O_PATH, Richard Henderson, 2012/08/03
- [Qemu-devel] [PATCH 04/10] linux-user: Sync fcntl.h bits with the kernel, Richard Henderson, 2012/08/03
- [Qemu-devel] [PATCH 06/10] linux-user: Allocate the right amount of space for non-fixed file maps, Richard Henderson, 2012/08/03
- [Qemu-devel] [PATCH 08/10] alpha-linux-user: Fix a3 error return with v0 error bypass.,
Richard Henderson <=
- [Qemu-devel] [PATCH 07/10] linux-user: Translate pipe2 flags; add to strace, Richard Henderson, 2012/08/03
- [Qemu-devel] [PATCH 09/10] alpha-linux-user: Properly handle the non-rt sigprocmask syscall., Richard Henderson, 2012/08/03
- [Qemu-devel] [PATCH 10/10] alpha-linux-user: Fix the getpriority syscall, Richard Henderson, 2012/08/03
- Re: [Qemu-devel] [PATCH v5 00/10] {alpha-}linux user improvements, Blue Swirl, 2012/08/04