Re: [Qemu-devel] [PATCH 27/34] qerror: add proper ErrorClass value for QERR_ macros

[Markus Armbruster]

Luiz Capitulino <address@hidden> writes:

> This commit replaces the place holder value for the ErrorClass
> argument with a proper ErrorClass value for all QERR_ macros.
>
> All current errors are mapped to GenericError, except for errors
> CommandNotFound, DeviceNotActive, DeviceNotFound, KVMMissingCap and
> MigrationExpected, which are maintained as they are today.
>
> Signed-off-by: Luiz Capitulino <address@hidden>
> ---
>  qerror.h | 140 
> +++++++++++++++++++++++++++++++--------------------------------
>  1 file changed, 70 insertions(+), 70 deletions(-)
>
> diff --git a/qerror.h b/qerror.h
> index bcc93f8..94346cb 100644
> --- a/qerror.h
> +++ b/qerror.h
> @@ -45,214 +45,214 @@ char *qerror_format(const char *fmt, QDict *error);
>   * Use scripts/check-qerror.sh to check.
>   */
>  #define QERR_ADD_CLIENT_FAILED \
> -    -1, "{ 'class': 'AddClientFailed', 'data': {} }"
> +    ERROR_CLASS_GENERIC_ERROR, "{ 'class': 'AddClientFailed', 'data': {} }"

Now we have two different things called "class" here.  Ugly.  But only
until PATCH 31 gets rid of the old one.  Okay.

[...]